Scan used instead of query

[sahilsharma011]

Describe the bug
Eloquent queries are using 'scan' whenever I use where function.

Schema

use BaoPham\DynamoDb\DynamoDbModel;

class DistributorInvoices extends DynamoDbModel
{
    protected $table = 'mytable';
    protected $dynamoDbIndexKeys = [
        'GSIndex' => [
            'hash' => 'hashkey',
            'range' => 'rangekey',
        ]
    ];

My Query

DynamoModel::where('hashkey',$hash)
                ->where('rangekey','between',[$range1,$range2])
                ->withIndex('GSIndex')
                ->toDynamoDbQuery();

Debug info
And this is what is returned when I dump the DynamoDbQuery.

RawDynamoDbQuery {#575
  +op: "Scan"
  +query: array:5 [
    "FilterExpression" => "#hash = :a1 AND (#range BETWEEN :a2 AND :a3)"
    "ExpressionAttributeNames" => array:2 [
      "#hash" => "hashkey"
      "#range" => "rangekey"
    ]
    "ExpressionAttributeValues" => array:3 [
      ":a1" => array:1 [
        "N" => "2"
      ]
      ":a2" => array:1 [
        "N" => "1531938600"
      ]
      ":a3" => array:1 [
        "N" => "1532024999"
      ]
    ]
    "TableName" => "mytable"
    "IndexName" => "GSIndex"
  ]
}

[baopham]

Good catch. Thanks for reporting. This should be a quick fix

[baopham]

hm... what version are you on? I'm not getting the same result: a244362 - the test passed for me.

[sahilsharma011]

I dig into the code a little bit and I found out that array_first laravel helper function was being used in Analyzer.php
This function was modified in laravel 5.3 where order of its parameters was reversed and that is why it is not working with my code because I have Laravel 5.2
Arrays - Key / Value Order Change

Currently I have fixed this in my project by overriding laravel's helper method

[baopham]

Ugh, this is the third time with laravel's helpers. I'll update that so it can be compatible with Laravel 5.2. Thanks for digging in the code!

[baopham]

This should be fixed now. Could you take a look? Thanks!

[sahilsharma011]

Yes it works fine now. Thank you.
Which laravel versions do you plan to support and will you be abandoning support from Laravel 5.2 any time soon?

[baopham]

I'm not planning to abandon support for Laravel 5.2 anytime soon. It's just that I'm actively developing in the latest(?) Laravel version so I didn't catch this bug. I'm going to have a task to migrate all the Laravel helpers I've used to the new class. PRs are welcome!