Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version_repo is not updated when Bazel version changes #25

Closed
meteorcloudy opened this issue Nov 8, 2023 · 5 comments · Fixed by #26 or bazel-contrib/rules_go#3747
Closed

version_repo is not updated when Bazel version changes #25

meteorcloudy opened this issue Nov 8, 2023 · 5 comments · Fixed by #26 or bazel-contrib/rules_go#3747

Comments

@meteorcloudy
Copy link
Collaborator

When switching the Bazel version, the bazel_features_version repo generated by

bazel_features/private/version_repo.bzl

Line 5 in 1f1b95a

version_repo = repository_rule(_version_repo_impl)
won't be automatically updated, which could result wrong feature detection result.
@meteorcloudy
Copy link
Collaborator Author

/cc @fmeum @Wyverald

@meteorcloudy
Copy link
Collaborator Author

I was switching between 6.4.0rc3 and 6.4.0.

@fmeum
Copy link
Member

fmeum commented Nov 8, 2023 •
edited
Loading

We could replace https://github.com/bazelbuild/bazel/blob/dc4f54f9c57a27b68ae0e8c0d21ad3cb68a3dc44/src/main/java/com/google/devtools/build/lib/packages/WorkspaceFactory.java#L363 with a regular struct field method that tracks whether a repository rule invoked it and then adds the return value to the marker file.

@fmeum fmeum mentioned this issue Nov 8, 2023
Merged
@fmeum
Copy link
Member

fmeum commented Nov 8, 2023

This would be difficult, but I think there is a much simpler solution: #26

meteorcloudy pushed a commit that referenced this issue Nov 8, 2023
@fmeum
Refetch version repositories when Bazel version changes (#26)
640a55a 
Since every version change requires a server restart, it suffices to
mark the version-dependent repos as `local`.

Fixes #25
@meteorcloudy
Copy link
Collaborator Author

Yeah, the new solution is also better since it works for existing Bazel versions! Thank you!!

fmeum added a commit to bazel-contrib/rules_go that referenced this issue Nov 8, 2023
@fmeum
Update bazel_features to v1.1.1
1497d9b 
Fixes bazel-contrib/bazel_features#25.
@fmeum fmeum mentioned this issue Nov 8, 2023
Merged
fmeum added a commit to bazel-contrib/rules_go that referenced this issue Nov 8, 2023
@fmeum
Update bazel_features to v1.1.1
457a88c 
Fixes bazel-contrib/bazel_features#25.
fmeum added a commit to bazel-contrib/rules_go that referenced this issue Nov 8, 2023
@fmeum
Update bazel_features to v1.1.1 (#3747)
6655d08 
Fixes bazel-contrib/bazel_features#25.
@fmeum fmeum mentioned this issue Nov 20, 2023
Closed
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Jan 26, 2024
@meteorcloudy @copybara-github
Update rules_python to 0.28.0 and .bazelversion to 7.0.2
0db3651 
We need to update rules_python to make sure a newer version of bazel_features is fetched with fixes for bazel-contrib/bazel_features#25

PiperOrigin-RevId: 601806824
Change-Id: I48f87cbbc1d71e884452b4100bc0582293fbf8b3
@meteorcloudy meteorcloudy mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@meteorcloudy @fmeum