Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature check for repository_ctx.getenv #94

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

gholms
Copy link
Contributor

@gholms gholms commented Feb 15, 2025

Bazel 7.1 and 8.0 added a repository_ctx.getenv function which lazily
declares environment variables (see bazelbuild/bazel#19511). This patch
adds a feature check for it for use outside of repository rule
implementations.

fmeum
fmeum previously requested changes Feb 15, 2025
@Wyverald Wyverald dismissed fmeum’s stale review February 20, 2025 01:41

see comment thread

@Wyverald Wyverald enabled auto-merge (squash) February 20, 2025 01:41
@Wyverald Wyverald merged commit 570c512 into bazel-contrib:main Feb 20, 2025
11 checks passed
@gholms gholms deleted the rctx-has-getenv branch February 20, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants