-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: workspace name imports not working with rollup #2086
Comments
I realised this error was caused by rollup being fed UMD outputs from ts_library. To workaround this I declared a new
I assume that shouldn't be required, but regardless, there are more problems:
For us, and surely many others, workspace-name imports are merely aliases -- cleaner alternatives to relative imports -- to a single ESM tree. |
Dupe of #2083 but thanks for extra info. We are working on it... |
Thanks Alex. Sorry I missed that one
…On Wed, 29 Jul 2020, 16:14 Alex Eagle, ***@***.***> wrote:
Dupe of #2083 <#2083>
but thanks for extra info. We are working on it...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2086 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXMMTID6OHDBNQ75QMOPTR6A4FNANCNFSM4PLQUAMQ>
.
|
Hey @alexeagle, just wondering what the latest is on this? |
let's followup on #2083 |
Is this a regression?
Yes, the previous version in which this bug was not present was: ....Yes. Worked in 1.7.0
Description
Hello. Our codebase, which I am migrating to rules_nodejs v2, uses workspace imports heavily. I followed the v2 migration advice in the wiki, but it doesn't work:
https://github.com/bazelbuild/rules_nodejs/wiki
I assume I am doing something wrong, but I don't know what and there's not much to go on.
I can recreate my problem inside of
examples/angular
:examples/angular/src/app/app.module.ts
Replace
with
BUILD.bazel
examples/angular/src/BUILD.bazel
Run
npm run serve-prod
Output
🐞 bug report
Affected Rule
The issue is caused by the rule: A clear and concise description of the problem...🔬 Minimal Reproduction
🔥 Exception or Error
🌍 Your Environment
Operating System:
Output of
bazel version
:3.4.1
Rules_nodejs version:
2.0.1
(Please check that you have matching versions between WORKSPACE file and
@bazel/*
npm packages.)Anything else relevant?
The text was updated successfully, but these errors were encountered: