Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation intro page is out of date with respect to Bazel-managed dependencies #2686

Closed
jfirebaugh opened this issue May 19, 2021 · 2 comments

Comments

@jfirebaugh
Copy link
Contributor

https://bazelbuild.github.io/rules_nodejs/ states:

It is up to the user to install packages into their node_modules directory, though the build tool can verify the contents.
...
In the nodejs rules, Bazel is not the package manager

My understanding is that this was true prior to the introduction of Bazel-managed dependencies, but with Bazel-managed dependencies, Bazel does manage node packages. To more accurately reflect the current status quo, this section should be updated to mention the (recommended) approach of using Bazel-managed dependencies with the workspace managed_directories attribute. Or perhaps the "Design" and "Hermeticity and reproducibility" sections should simply be deleted, since the same material is more accurately covered on the Dependencies page.

@alexeagle
Copy link
Collaborator

Thanks for filing, that's good timing since we just launched a new docsite. I agree this content was the first thing I wrote four years ago and should just be deleted.

@alexeagle
Copy link
Collaborator

the reference to #1 will be missed 💀

alexeagle added a commit that referenced this issue May 26, 2021
twheys pushed a commit to twheys/rules_nodejs that referenced this issue Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants