Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to not restart the server and only rebuild the data dependencies of a job (while leaving it running) #29

Closed
achew22 opened this issue Sep 6, 2017 · 10 comments

Comments

@achew22
Copy link
Member

achew22 commented Sep 6, 2017

To quote @mprobst,

I found that to be more useful than respawning the binary. In
particular for servers that often take a long time to start, it's useful to
rebuild their assets (think: JS, TypeScript, etc) without restarting the
server.

@alexeagle
Copy link
Contributor

Definitely need this for Karma, it takes a while for karma to start up, launch its server, launch and connect to a browser.

@achew22
Copy link
Member Author

achew22 commented Sep 22, 2017

@alexeagle Do you know if this is done with a bazel query (seems likely to be slow) or by parsing the BUILD file directly or is there another mechanism that I'm unaware of

@alexeagle
Copy link
Contributor

alexeagle commented Sep 22, 2017 via email

@achew22
Copy link
Member Author

achew22 commented Sep 22, 2017

100% agree on that, but how do you detect if the target has the tag "no_seriously_dont_kill_me". The only idea I have off hand is to do bazel query attr(tags, no_seriously_dont_kill_me, //path/to:target) and see if the target is returned. Do you have any other ideas on that?

@alexeagle
Copy link
Contributor

Can we always leave binaries running under ibazel run? I don't think iblaze has a feature to restart the binary on changes?

@achew22
Copy link
Member Author

achew22 commented Sep 24, 2017

@mrmeku and I worked on this Friday night (mrmeku@54930bf) by refactoring the way commands are launched. We got pretty far and think we have a plan for handling the numerous edge cases. @mrmeku is going to fix up the tests and send me a PR which I'll merge then it'll be pretty simple to add the support for not restarting the binary on change

@alexeagle
Copy link
Contributor

alexeagle commented Sep 24, 2017 via email

@mrmeku
Copy link
Collaborator

mrmeku commented Nov 15, 2017

@achew22 I think this can be closed now can't it?

@achew22
Copy link
Member Author

achew22 commented Nov 15, 2017

I want to close it when it's documented and e2e tested. It's not done till it's documented 😉

@achew22
Copy link
Member Author

achew22 commented Dec 11, 2017

I think this is reasonably well e2e tested now. Closing.

@achew22 achew22 closed this as completed Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants