Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibazel writes IBAZEL_BUILD_COMPLETED FAILURE to stdin even for successful builds #56

Closed
alexeagle opened this issue Nov 1, 2017 · 1 comment · Fixed by #70
Closed

ibazel writes IBAZEL_BUILD_COMPLETED FAILURE to stdin even for successful builds #56

alexeagle opened this issue Nov 1, 2017 · 1 comment · Fixed by #70

Comments

@alexeagle
Copy link
Contributor

In my prototype devserver that uses ibazel from HEAD, I had to listen for FAILURE
https://github.com/alexeagle/angular-bazel-example/blob/98af46d27bab378e4ed5f14799c80578f0287d55/airplane/devserver.js#L9
because ibazel never reports SUCCESS
@alexeagle alexeagle mentioned this issue Nov 1, 2017
Closed
@achew22 achew22 mentioned this issue Nov 11, 2017
Merged
@mrmeku
Copy link
Collaborator

mrmeku commented Nov 14, 2017

I'm going to document a bit of research I've done on this bug. It appears that the "error" that ibazel identifies is one is causes it self. To see if an error is produced ibazel calls the .Wait method on the Cmd object it uses to represent an invocation of bazel. However, when it calls Wait to see if there was an error the error produced reads "Wait was already called". So I think the key to fixing this bug is to ensure that wait is only called once. If we do that then bazel should go down the code path which logs IBAZEL_BUILD_COMPLETED SUCCESS

@mrmeku mrmeku mentioned this issue Nov 15, 2017
Closed
achew22 added a commit that referenced this issue Nov 15, 2017
@achew22
Notify command now watches on the correct tag. (#60)
e5225fd 
Additoinally it emits the correct signals, stdin (from the perspective
of the code living in the repo being built), and environment variables.

Fixes: #57
Fixes: #56
Issue: #55
mrmeku added a commit to mrmeku/bazel-watcher that referenced this issue Nov 15, 2017
@mrmeku
Notify of changes command: Correctly identify when a build completes
c0c2c3c 
(fixes bazelbuild#56) Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.
@mrmeku mrmeku mentioned this issue Nov 15, 2017
Merged
mrmeku added a commit to mrmeku/bazel-watcher that referenced this issue Nov 15, 2017
@mrmeku
Notify of changes command: Correctly identify when a build completes
d2f9f89 
(fixes bazelbuild#56) Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.
mrmeku added a commit to mrmeku/bazel-watcher that referenced this issue Nov 15, 2017
@mrmeku
Notify of changes command: Correctly identify when a build completes
c724c0d 
(fixes bazelbuild#56) Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.
mrmeku added a commit to mrmeku/bazel-watcher that referenced this issue Nov 15, 2017
@mrmeku
Notify of changes command: Correctly identify when a build completes
0561b60 
(fixes bazelbuild#56) Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.
mrmeku added a commit to mrmeku/bazel-watcher that referenced this issue Nov 15, 2017
@mrmeku
Notify of changes command: Correctly identify when a build completes
aeacaab 
(fixes bazelbuild#56) Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.
achew22 pushed a commit that referenced this issue Nov 16, 2017
@mrmeku @achew22
Notify of changes command: Correctly identify when a build completes (#…
8955192 
…70)

Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.

Fixes: #56
borkaehw pushed a commit to lucidsoftware/bazel-watcher that referenced this issue Jul 30, 2018
@achew22
Notify command now watches on the correct tag. (bazelbuild#60)
c63ec52 
Additoinally it emits the correct signals, stdin (from the perspective
of the code living in the repo being built), and environment variables.

Fixes: bazelbuild#57
Fixes: bazelbuild#56
Issue: bazelbuild#55
borkaehw pushed a commit to lucidsoftware/bazel-watcher that referenced this issue Jul 30, 2018
@mrmeku @achew22
Notify of changes command: Correctly identify when a build completes (b…
f1234a1 
…azelbuild#70)

Prior to this change everytime ibazel rebuilt a bazel command it
would think that the build failed even if it succeeded.
The issue was the the underlying command object was being
called with both Run()# On branch master and subsequently Wait().
Becuase the command had already been run,
the invocation of Wait() always produced an error.

Fixes: bazelbuild#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexeagle @mrmeku