Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stay alive after source query failure #200

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Stay alive after source query failure #200

merged 3 commits into from
Dec 7, 2018

Conversation

dougkoch
Copy link
Member

@dougkoch dougkoch commented Dec 6, 2018

Fixes #194

@dougkoch dougkoch force-pushed the stay-alive-after-source-query-failure branch from e90ce37 to 27a1381 Compare December 6, 2018 10:12
achew22
achew22 reviewed Dec 6, 2018
View reviewed changes
Copy link
Member

@achew22 achew22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test in the e2e directory to demonstrate this new behavior?

@achew22 achew22 merged commit 1933593 into bazelbuild:master Dec 7, 2018
@IgorMinar
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achew22 achew22 achew22 left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougkoch @IgorMinar @achew22 @googlebot