Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows binary resolution on node #253

Merged
merged 1 commit into from
May 1, 2019
Merged

Fix windows binary resolution on node #253

merged 1 commit into from
May 1, 2019

Conversation

rerion
Copy link
Contributor

@rerion rerion commented May 1, 2019

Relevant issue:

#105 (comment)

@rerion rerion requested a review from achew22 as a code owner May 1, 2019 14:01
@achew22 achew22 merged commit 398a05c into bazelbuild:master May 1, 2019
@achew22
Copy link
Member

achew22 commented May 1, 2019

I just released this to NPM as v0.10.2. Could I have you confirm this is fixed now?

@rerion
Copy link
Contributor Author

rerion commented May 1, 2019

Yes, this is fixed

@rerion rerion deleted the fix-index-js branch May 1, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achew22 achew22 achew22 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerion @achew22 @googlebot