Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify listening processes when a build starts. #265

Merged
merged 1 commit into from
May 29, 2019

Conversation

DavidANeil
Copy link
Contributor

No description provided.

@DavidANeil DavidANeil requested a review from achew22 as a code owner May 29, 2019 00:01
@DavidANeil DavidANeil force-pushed the davidneil-build-started branch from 37295bd to af0db08 Compare May 29, 2019 00:08
@achew22
Copy link
Member

achew22 commented May 29, 2019

@DavidANeil, looks good to me. Merging.

PS: What are you going to use this for? It seems like you're putting some work into iBazel lately. Any chance it's open source? I'd love to see how things are being used.

@achew22 achew22 merged commit 7d93aa5 into bazelbuild:master May 29, 2019
@DavidANeil
Copy link
Contributor Author

We have been using Bazel for our backend with iBazel for developers and now we are getting frontend Bazel set up and so all of my PRs relate to helping the frontend experience be great for developers. Which is why there has been an uptick recently.

This PR is to allow our asset server to just be running an iBazel build on all of the transpiled sources and then serve them immediately if a build is not in progress, rather than waiting for a request for an asset, then building it, then serving it.

#262 is to automatically add missing dependencies to BUILD files for our TypeScript.

bazelbuild/bazel#8322 is to make it so we can use iBazel to debug our Karma/Jasmine unit tests. So the chrome window can stay open.

Unfortunately none of our use of this is in open sourced code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants