Create NotifyCommand mode #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
approved these changes
Sep 29, 2017
| b := &mock_bazel.MockBazel{} | ||
| b.WaitError(nil) | ||
| bazelNew = func() bazel.Bazel { return b } | ||
| defer func() { bazelNew = oldBazelNew }() |
There was a problem hiding this comment.
This might be might lack of go skill talking but it seems like these two lines are the equivelent of writing bazelNew = oldBazelNew. Why defer this function?
There was a problem hiding this comment.
Defer executes a function at the end of the current function. This makes the bazelNew mock get reset after everything is done.
| c.NotifyOfChanges() | ||
| b.WaitError(nil) | ||
| c.NotifyOfChanges() | ||
|
|
There was a problem hiding this comment.
Might be good to expect that isSubprocessRunning to be true at this point
There was a problem hiding this comment.
Huh, turns out that isn't possible to do because I'm using cmd.CombinedOutput which starts the job. I'm going to return it to the old way and work instead on an end to end test which is a better test anyway.
In this mode the command is notified that the build has completed over stdin. The program can then intelligently react and decide to reload dependencies without having to restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this mode the command is notified that the build has completed over
stdin. The program can then intelligently react and decide to reload
dependencies without having to restart.