-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rules_go to 0.7.0 #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
Check this please |
Jenkins, test this please |
Andrew: they need to add 2FA then I can add them to the bazelbuild org and
follow-up
…On Sun, Nov 12, 2017 at 11:07 PM Andrew Z Allen ***@***.***> wrote:
@damienmg <https://github.com/damienmg>, I just added @dougkoch
<https://github.com/dougkoch> as a contributor to this project. Do I need
to do more to whitelist him to run PRs in Jenkins?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf-h0QeejDCgNnCWA-5n-Y0QaMuEFks5s1-qzgaJpZM4QauMS>
.
|
@damienmg I just enabled 2FA |
I invited you to the bazelbuild org, once you accept, go to
https://github.com/orgs/bazelbuild/people?utf8=%E2%9C%93&query=dougkoch and
in front of your name, on the third column, change "Private" to "Public" so
your profile show you are in the bazelbuild org.
Once done so, you will have the power to trigger our CI, every PR from you
will automatically trigger it and you will be able to trigger it with the
sentence "test this please". Make sure to eyeball a PR for security aspect
before triggering a build.
…On Mon, Nov 13, 2017 at 11:27 AM Doug Koch ***@***.***> wrote:
@damienmg <https://github.com/damienmg> I just enabled 2FA
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf4tI6FOwsldUCRpxeYdrBd20Bm9Nks5s2JgKgaJpZM4QauMS>
.
|
Closed
mrmeku
pushed a commit
to mrmeku/bazel-watcher
that referenced
this pull request
Nov 15, 2017
mrmeku
pushed a commit
to mrmeku/bazel-watcher
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an Ubuntu user, I had the same issue with rules_go that @genehwung mentioned in #26. This has since been fixed by bazel-contrib/rules_go#850