Add sep keyword argument to fail
#21961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument was already available on 'print' and is necessary for full control over the formatting of error messages that rely on StarlarkValue's `debugPrint`. Work towards bazelbuild#20486
fmeum
requested review from
tetromino
and removed request for
tetromino and
brandjon
github-actions
bot
added
the
awaiting-review
|
@tetromino Would you be available to review this (small) change? It's a follow-up to 3abbf20. |
fmeum
changed the title
sep keyword argument to fail
|
@bazel-io fork 7.2.0 |
tetromino
added
team-Starlark-Interpreter
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 15, 2024
The argument was already available on 'print' and is necessary for full control over the formatting of error messages that rely on StarlarkValue's `debugPrint`. Work towards bazelbuild#20486 Closes bazelbuild#21961. PiperOrigin-RevId: 625022818 Change-Id: I895b5844d8543f936fc31d367b12bc6291a10bf8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
The argument was already available on 'print' and is necessary for full control over the formatting of error messages that rely on StarlarkValue's `debugPrint`. Work towards #20486 Closes #21961. PiperOrigin-RevId: 625022818 Change-Id: I895b5844d8543f936fc31d367b12bc6291a10bf8 Commit 6b2e0db Co-authored-by: Fabian Meumertzheim <[email protected]>
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
The argument was already available on 'print' and is necessary for full control over the formatting of error messages that rely on StarlarkValue's `debugPrint`. Work towards bazelbuild#20486 Closes bazelbuild#21961. PiperOrigin-RevId: 625022818 Change-Id: I895b5844d8543f936fc31d367b12bc6291a10bf8
|
The changes in this PR have been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument was already available on 'print' and is necessary for full control over the formatting of error messages that rely on StarlarkValue's
debugPrint.Work towards #20486