Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//contrib/push-all.bzl container_push fails #609

Closed
kevingessner opened this issue Dec 12, 2018 · 3 comments · Fixed by #651
Closed

//contrib/push-all.bzl container_push fails #609

kevingessner opened this issue Dec 12, 2018 · 3 comments · Fixed by #651
Assignees
@smukherj1

Comments

@kevingessner
Copy link
Contributor

Pushes with that rule fail with an error as of 5eb0728:

usage: fast_pusher_.py [-h] --name NAME [--tarball TARBALL] [--config CONFIG]
                       [--manifest MANIFEST] [--digest DIGEST] [--layer LAYER]
                       [--stamp-info-file STAMP_INFO_FILE] [--oci]
                       [--client-config-dir CLIENT_CONFIG_DIR]
                       [--stderrthreshold STDERRTHRESHOLD]
fast_pusher_.py: error: argument --name is required

The args being used for push-tag-sh.tpl are no longer correct, so the pusher call is invalid.
@ixdy
Copy link
Contributor

ixdy commented Jan 10, 2019

cc @ceason @nlopezgi

@ixdy
Copy link
Contributor

ixdy commented Jan 10, 2019

x-ref #591 which appears to be the breaking PR

@ixdy ixdy mentioned this issue Jan 10, 2019
Merged
@smukherj1 smukherj1 self-assigned this Jan 10, 2019
smukherj1 added a commit to smukherj1/rules_docker that referenced this issue Jan 10, 2019
@smukherj1
Fix container bundle pusher broken by bazelbuild#591
ada2fe0 
This fixes bazelbuild#609. Also added end to end test to verify bundle pusher and
regular pusher upload legal images.
@smukherj1 smukherj1 mentioned this issue Jan 10, 2019
Merged
smukherj1 added a commit to smukherj1/rules_docker that referenced this issue Jan 10, 2019
@smukherj1
Fix container bundle pusher broken by bazelbuild#591
22b81a9 
This fixes bazelbuild#609. Also added end to end test to verify bundle pusher and
regular pusher upload legal images.
smukherj1 added a commit to smukherj1/rules_docker that referenced this issue Jan 11, 2019
@smukherj1
Fix container bundle pusher broken by bazelbuild#591
8fa0e2d 
This fixes bazelbuild#609. Also added end to end test to verify bundle pusher and
regular pusher upload legal images.
smukherj1 added a commit that referenced this issue Jan 11, 2019
@smukherj1
Fix container bundle pusher broken by #591 (#651)
e4b4fc2 
* Fix container bundle pusher broken by #591

This fixes #609. Also added end to end test to verify bundle pusher and
regular pusher upload legal images.

* Fix typo & formatting

* Address review comments
@kevingessner
Copy link
Contributor Author

Thanks @ixdy and @smukherj1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smukherj1 smukherj1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix container bundle pusher broken by #591 smukherj1/rules_docker
3 participants
@kevingessner @ixdy @smukherj1