-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rules_pkg repository instead of deprecated pkg files #1483
Use rules_pkg repository instead of deprecated pkg files #1483
Conversation
Closing temporarily pending more testing. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
19dfc85
to
b593be9
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
b593be9
to
e6bb421
Compare
e6bb421
to
b957cbb
Compare
b957cbb
to
54a21a7
Compare
/gcbrun |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dannysullivan, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This repository is currently using a deprecated version of Bazel's package management code. This PR updates all references to
@bazel_tools//tools/build_defs/pkg
so that they instead use@rules_pkg//
, which is maintained.Note: this PR does not replace
rules_docker
's custom version ofbuild_tar.py
with the one contained inrules_pkg
. It should not result in any changed behavior at all.