Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rules_pkg repository instead of deprecated pkg files #1483

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

dannysullivan
Copy link
Contributor

@dannysullivan dannysullivan commented Apr 27, 2020

This repository is currently using a deprecated version of Bazel's package management code. This PR updates all references to @bazel_tools//tools/build_defs/pkg so that they instead use @rules_pkg//, which is maintained.

Note: this PR does not replace rules_docker's custom version of build_tar.py with the one contained in rules_pkg. It should not result in any changed behavior at all.

@dannysullivan
Copy link
Contributor Author

Closing temporarily pending more testing.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@smukherj1
Copy link
Collaborator

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dannysullivan, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbe-toolchains-pr-bot rbe-toolchains-pr-bot merged commit bf4c4a3 into bazelbuild:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants