Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolchain_type public #1580

Conversation

austince
Copy link
Contributor

@austince austince commented Aug 5, 2020

Closes #1579

@austince
Copy link
Contributor Author

austince commented Aug 5, 2020

/assign @smukherj1

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austince, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smukherj1
Copy link
Collaborator

/gcbrun

@rbe-toolchains-pr-bot rbe-toolchains-pr-bot merged commit d9157b5 into bazelbuild:master Aug 6, 2020
@austince austince deleted the feat/toolchains/public-toolchain-type branch August 6, 2020 13:36
@austince
Copy link
Contributor Author

austince commented Aug 6, 2020

Thanks for the quick review and merge @smukherj1! What's the release cycle for this project like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make toolchain_type public
5 participants