Fix the root directory when building for Linux on Windows. #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the .tar file gets a weird structure that is not well interpreted in Linux; e.g. files get names like ".\a\b\c\file" (that is a filename, not a path).
|
Please let me know if there is a better way to know if the Bazel host is Windows; I could not find a consistent approach elsewhere in rules_docker. |
|
/assign @alex1545 |
smukherj1
approved these changes
Sep 2, 2020
|
/gcbrun |
Oops, I may have clicked the wrong button. I was seeing a message saying this branch was out of date with the master. What is the next step for this Pull Request? |
|
/gcbrun |
smukherj1
approved these changes
Sep 9, 2020
|
/gcbrun |
smukherj1
approved these changes
Sep 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: faube, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgdolan
pushed a commit
to cgdolan/rules_docker
that referenced
this pull request
Sep 13, 2020
…d#1609) Otherwise, the .tar file gets a weird structure that is not well interpreted in Linux; e.g. files get names like ".\a\b\c\file" (that is a filename, not a path). Co-authored-by: Suvanjan Mukherjee <[email protected]>
jamiees2
pushed a commit
to jamiees2/rules_docker
that referenced
this pull request
Sep 23, 2020
…d#1609) Otherwise, the .tar file gets a weird structure that is not well interpreted in Linux; e.g. files get names like ".\a\b\c\file" (that is a filename, not a path). Co-authored-by: Suvanjan Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the .tar file gets a weird structure that is not well interpreted in Linux; e.g. files get names like ".\a\b\c\file" (that is a filename, not a path).