Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x support for puller and loader binaries #1645

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

srajmane
Copy link
Contributor

@srajmane srajmane commented Oct 7, 2020

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@srajmane
Copy link
Contributor Author

srajmane commented Oct 7, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@srajmane
Copy link
Contributor Author

srajmane commented Oct 9, 2020

@smukherj1 @alex1545 Could you please have a look?

@smukherj1
Copy link
Collaborator

Hi there,

Looks like the commits have their email address set to a *****@users.noreply.github.com address. Unfortunately, for the CLA detection to work, the commits need to be the same as the email you used to sign the CLA. This might be because you have anonymous commits set in your Github settings.

Otherwise, PR LGTM

@srajmane
Copy link
Contributor Author

Thanks @smukherj1
I have updated my commit with CLA signed email address.

@smukherj1
Copy link
Collaborator

can you sync changes from master?

@srajmane
Copy link
Contributor Author

can you sync changes from master?

@smukherj1 Branch in sync with the master now.

@smukherj1
Copy link
Collaborator

apologies I merged a different PR and need to sync this again. Not sure why it won't let me do the sync. Can you sync again? I promise I'll merge this next!

@srajmane
Copy link
Contributor Author

apologies I merged a different PR and need to sync this again. Not sure why it won't let me do the sync. Can you sync again? I promise I'll merge this next!

@smukherj1 Please check now, resynced my branch.

@smukherj1
Copy link
Collaborator

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smukherj1, srajmane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbe-toolchains-pr-bot rbe-toolchains-pr-bot merged commit aad9436 into bazelbuild:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants