Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrate remaining examples #1799

Closed
wants to merge 62 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
cda3afc
Add experimental github actions ci job
pcj Mar 17, 2021
077e01c
Temporarily remove size-label action
pcj Mar 17, 2021
18cc89c
Remove .bazelrc copy step
pcj Mar 17, 2021
48131b6
Update bazelisk to latest
pcj Mar 17, 2021
7ced36a
Remove travis (pull request limits too low
pcj Mar 17, 2021
5625829
Change ci trigger
pcj Mar 17, 2021
1e1edb8
Upgrade to actions/cache@v2
pcj Mar 17, 2021
024fdbf
Remove cloudbuild.yaml for //:structure_test_at_workspace_root
pcj Mar 17, 2021
092509a
Add experiment bes_backend api.bzl.io
pcj Mar 17, 2021
a25fffe
Remove install_pkgs_reproducibility_test
pcj Mar 17, 2021
cd783a4
Remove tests/docker cloudbuild.yaml file
pcj Mar 17, 2021
4afc9ab
Add job for tests/container
pcj Mar 17, 2021
b8a1a68
Add job for testing/java_image
pcj Mar 17, 2021
7bb4884
Stream build results from buildkite
pcj Mar 17, 2021
d6c040c
Copy root .bazelrc to nested workspace
pcj Mar 17, 2021
2b07e60
Fix copy command
pcj Mar 17, 2021
3f96b68
add extra build_metadata
pcj Mar 17, 2021
1ef2e29
Add extra build_metadata
pcj Mar 17, 2021
24076bc
See which tests pass on buildkite
pcj Mar 17, 2021
da4f685
Buildkite iteration 1
pcj Mar 17, 2021
3dd1dba
temp disable gh
pcj Mar 17, 2021
6ad7023
Buildkite iteration 2
pcj Mar 17, 2021
718f700
Buildkite iteration 3
pcj Mar 17, 2021
d35424c
Buildkite iteration 4
pcj Mar 17, 2021
b6b4428
Buildkite iteration 5
pcj Mar 17, 2021
9973430
Buildkite iteration 6
pcj Mar 17, 2021
18294ae
Buildkite iteration 6
pcj Mar 17, 2021
8974596
Buildkite iteration 7
pcj Mar 17, 2021
a51f058
Buildkite iteration 8
pcj Mar 17, 2021
77634fb
Migrate presubmit off legacy format
pcj Mar 17, 2021
80ebc3e
Add testing/examples basic to presubmit
pcj Mar 17, 2021
fd0399d
Migrate testing/examples/basic to buildkite
pcj Mar 17, 2021
fbac7e1
Add testing/java_image to buildkite
pcj Mar 17, 2021
ff9b8af
Add testing/examples/java_app to buildkite
pcj Mar 17, 2021
27e7a7b
java image is build, not test
pcj Mar 17, 2021
79c3f5a
Migrate testing/java_image to buikdkite
pcj Mar 17, 2021
5718779
Add testing/download_pkgs_at_root to buildkite
pcj Mar 17, 2021
05f16a0
Add testing/custom_toolchain_flags to buildkite
pcj Mar 17, 2021
a3a63da
Migrate testing/examples/extended/cloudbuild.yaml to buildkite
pcj Mar 17, 2021
43e1751
Migrate testing/examples/java_app/cloudbuild.yaml to buildkite
pcj Mar 17, 2021
6c16de8
Migrate testing/download_pkgs_at_root/cloudbuild.yaml to buildkite
pcj Mar 17, 2021
bd5b5c8
Migrate testing/custom_toolchain_flags/cloudbuild.yaml to buildkite
pcj Mar 17, 2021
da7ea18
Add //run_instruction_arbitrary:all to buildkite
pcj Mar 17, 2021
9bed290
Remove cloudbuild test already on buildkite
pcj Mar 17, 2021
ade4362
Revert add //run_instruction_arbitrary:all to buildkite
pcj Mar 17, 2021
26b3e68
Remove tests dependent on gcr.io/asci-toolchain/container_release_too…
pcj Mar 30, 2021
1f73bdc
Remove pusher and loader cloudbuild script
pcj Mar 30, 2021
679fdf1
Use bazel 3.5.0 (most recent available for pinned bazel-toolchains)
pcj Mar 30, 2021
48a1c04
Update ubuntu keyserver gpg hash
pcj Mar 30, 2021
6d43349
Remove bazelversion file (breaks tests?)
pcj Mar 30, 2021
28ebe7d
Try at 4.0.0 again
pcj Mar 30, 2021
1b95b9d
Revert gpg key hash change
pcj Mar 30, 2021
5286579
Revert Revert gpg key hash change
pcj Mar 30, 2021
12cdc3d
Try 3.5.0 AGAIN
pcj Mar 30, 2021
ba89cb3
move derivative_with_volume_repro_test off buildkite
pcj Mar 30, 2021
229988e
Label tests with buildkite-incompatible
pcj Mar 30, 2021
579d4c8
Use recursive all-tests on buildkite
pcj Mar 30, 2021
87ca225
Exclude test_compare_ids_test_one_tar_no_id_fails
pcj Mar 30, 2021
c8e1b32
Add buildkite macos platform
pcj Mar 30, 2021
10ce363
Macos iteration 2
pcj Mar 30, 2021
2911b06
Exclude docker_run.bzl from macox
pcj Mar 30, 2021
5a34a0f
Migrate remaining examples.
gravypod Apr 4, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
286 changes: 48 additions & 238 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,251 +7,61 @@ buildifier:
# rule-impl-return, uninitialized, return-value, rule-impl-return
# TODO (suvanjan): Re-enable once issues are fixed.
warnings: "attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,confusing-name,constant-glob,ctx-actions,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,function-docstring,git-repository,http-archive,integer-division,load,load-on-top,module-docstring,name-conventions,native-build,native-package,no-effect,out-of-order-load,output-group,package-name,package-on-top,redefined-variable,repository-name,same-origin-load,string-iteration,unreachable,unsorted-dict-items,unused-variable"
platforms:
ubuntu1604:
bazel: 3.5.0 # keep in sync with .bazelversion
tasks:
default_workspace_ubuntu1804:
platform: ubuntu1804
test_targets:
- "--"
# Tests that don't use the 'docker' tool.
- "//container/go/pkg/compat:go_default_test"
- "//container/go/pkg/oci:go_default_test"
- "//container:image_test"
- "//docker/util:config_stripper_test"
- "//tests/container:alpine_custom_attr_digest_test"
- "//tests/container:alpine_linux_armv6_tar_test_image_tar"
- "//tests/container:architecture_test"
- "//tests/container:basic_windows_image_test"
- "//tests/container:build_tar_test"
- "//tests/container:distroless_fixed_id_digest_test"
- "//tests/container:distroless_fixed_id_image_digest_test"
- "//tests/container:k8s_pause_arm64_digest_test"
- "//tests/container:new_alpine_linux_armv6_image_tar_digest_test"
- "//tests/container:new_alpine_linux_ppc64le_image_oci_go_join_layers_test"
- "//tests/container:new_distroless_base_oci_test_0_tar_gz"
- "//tests/container:new_distroless_base_oci_test_config"
- "//tests/container:pause_tar_test_0_tar_gz"
- "//tests/container:pause_tar_test_1_tar_gz"
- "//tests/container:pause_tar_test_config"
- "//tests/container:set_cmd_test_host"
- "//tests/container:special_characters_test"
- "//tests/container:test_digest_output1"
- "//tests/container:test_digest_output2"
- "//tests/container:test_push_digest_output"
- "//tests/contrib/automatic_container_release:test_metadata_merge"
- "//tests/contrib/automatic_container_release:test_packages_metadata"
- "//tests/contrib:rename_image_test"
- "//tests/contrib:test_compare_ids_test"
- "//tests/contrib:test_compare_ids_test_diff_ids_fails_no_regex"
- "//tests/contrib:test_id_compare_ids_test"
- "//tests/docker/package_managers:test_download_pkgs_rule"
- "//tests/docker/package_managers:test_install_pkgs_rule"
- "//tests/docker/package_managers:test_download_pkgs_docker_cp"
- "//tests/docker/package_managers:test_download_pkgs_docker_run"
- "//tests/docker/util:test_container_commit_rule"
- "//tests/docker/util:test_container_extract_rule"
- "//tests/docker/util:test_extract_script"
- "//tests/docker/util:test_container_commit_layer_rule"
- "//tests/docker/util:test_container_commit_layer_metadata"

# Disabled tests that do not run in BuildKite CI.
# The targets listed below is not an exhaustive list of disabled targets
# and serves for informational purposes.

- "-//tests/docker/security/..."
# tests/docker/security require gcloud
- "-//tests/contrib:derivative_with_volume_repro_test"
- "-//tests/contrib:random_file_img_non_repro_test"
- "-//tests/contrib:rbe-test-xenial_repro_test"
- "-//tests/contrib:set_cmd_repro_test"
- "-//tests/contrib:test_compare_ids_test_diff_ids_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails_multi_regex"
- "-//tests/contrib:test_compare_ids_test_no_images_with_id_fails"
- "-//tests/contrib:test_compare_ids_test_one_tar_no_id_fails"
- "-//tests/contrib:test_compare_ids_test_wrong_id_fails"
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
# tests/contrib/test_compare_ids_test_* expect 'bazel' on path
# container_test and configs_test targets require 'docker' and are disabled
- //...
test_flags:
- "--action_env=PATH"
- "--test_output=errors"
ubuntu1804:
- --config=buildkite_default
default_workspace_macos:
platform: macos
test_targets:
- "--"
# Tests that don't use the 'docker' tool.
- "//container/go/pkg/compat:go_default_test"
- "//container/go/pkg/oci:go_default_test"
- "//container:image_test"
- "//docker/util:config_stripper_test"
- "//tests/container:alpine_custom_attr_digest_test"
- "//tests/container:alpine_linux_armv6_tar_test_image_tar"
- "//tests/container:architecture_test"
- "//tests/container:basic_windows_image_test"
- "//tests/container:build_tar_test"
- "//tests/container:distroless_fixed_id_digest_test"
- "//tests/container:distroless_fixed_id_image_digest_test"
- "//tests/container:k8s_pause_arm64_digest_test"
- "//tests/container:new_alpine_linux_armv6_image_tar_digest_test"
- "//tests/container:new_alpine_linux_ppc64le_image_oci_go_join_layers_test"
- "//tests/container:new_distroless_base_oci_test_0_tar_gz"
- "//tests/container:new_distroless_base_oci_test_config"
- "//tests/container:pause_tar_test_0_tar_gz"
- "//tests/container:pause_tar_test_1_tar_gz"
- "//tests/container:pause_tar_test_config"
- "//tests/container:set_cmd_test_host"
- "//tests/container:special_characters_test"
- "//tests/container:test_digest_output1"
- "//tests/container:test_digest_output2"
- "//tests/container:test_push_digest_output"
- "//tests/contrib/automatic_container_release:test_metadata_merge"
- "//tests/contrib/automatic_container_release:test_packages_metadata"
- "//tests/contrib:rename_image_test"
- "//tests/contrib:test_compare_ids_test"
- "//tests/contrib:test_compare_ids_test_diff_ids_fails_no_regex"
- "//tests/contrib:test_id_compare_ids_test"
- "//tests/docker/package_managers:test_download_pkgs_rule"
- "//tests/docker/package_managers:test_install_pkgs_rule"
- "//tests/docker/package_managers:test_download_pkgs_docker_cp"
- "//tests/docker/package_managers:test_download_pkgs_docker_run"
- "//tests/docker/util:test_container_commit_rule"
- "//tests/docker/util:test_container_extract_rule"
- "//tests/docker/util:test_extract_script"
- "//tests/docker/util:test_container_commit_layer_rule"
- "//tests/docker/util:test_container_commit_layer_metadata"


# Disabled tests that do not run in BuildKite CI.
# The targets listed below is not an exhaustive list of disabled targets
# and serves for informational purposes.

- "-//tests/docker/security/..."
# tests/docker/security require gcloud
- "-//tests/contrib:derivative_with_volume_repro_test"
- "-//tests/contrib:random_file_img_non_repro_test"
- "-//tests/contrib:rbe-test-xenial_repro_test"
- "-//tests/contrib:set_cmd_repro_test"
- "-//tests/contrib:test_compare_ids_test_diff_ids_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails_multi_regex"
- "-//tests/contrib:test_compare_ids_test_no_images_with_id_fails"
- "-//tests/contrib:test_compare_ids_test_one_tar_no_id_fails"
- "-//tests/contrib:test_compare_ids_test_wrong_id_fails"
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
# tests/contrib/test_compare_ids_test_* expect 'bazel' on path
# container_test and configs_test targets require 'docker' and are disabled
- //...
test_flags:
- "--action_env=PATH"
- "--test_output=errors"
macos:
build_targets:
- "--"
- "//tests/container/..."
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
build_flags:
- "--action_env=PATH"
# For tests/container:set_env_make_vars_test
- "--define=ENV_KEY=my_key"
- "--define=ENV_VALUE=my_value"
# Needed because register_platforms is apparently not respecting order of
# platforms passed:
- "--extra_execution_platforms=@local_config_platform//:host,@io_bazel_rules_docker//platforms:local_container_platform"
- --config=buildkite_default
- --deleted_packages=tests/contrib,tests/docker/util
testing_examples:
platform: ubuntu1804
working_directory: testing/examples
shell_commands:
- cp ../../.bazelrc .
test_targets:
- "--"
- "//tests/container:alpine_custom_attr_digest_test"
- "//tests/container:alpine_linux_armv6_tar_test_image_tar"
- "//tests/container:architecture_test"
- "//tests/container:basic_windows_image_test"
- "//tests/container:build_tar_test"
- "//tests/container:distroless_fixed_id_digest_test"
- "//tests/container:distroless_fixed_id_image_digest_test"
- "//tests/container:k8s_pause_arm64_digest_test"
- "//tests/container:new_alpine_linux_armv6_image_tar_digest_test"
- "//tests/container:new_alpine_linux_ppc64le_image_oci_go_join_layers_test"
- "//tests/container:new_distroless_base_oci_test_0_tar_gz"
- "//tests/container:new_distroless_base_oci_test_config"
- "//tests/container:pause_tar_test_0_tar_gz"
- "//tests/container:pause_tar_test_1_tar_gz"
- "//tests/container:pause_tar_test_config"
- "//tests/container:set_cmd_test_host"
- "//tests/container:special_characters_test"
- "//tests/container:test_digest_output1"
- "//tests/container:test_digest_output2"
- "//tests/container:test_push_digest_output"
- "//tests/contrib:rename_image_test"
- "//tests/contrib:test_compare_ids_test"
- "//tests/contrib:test_compare_ids_test_diff_ids_fails_no_regex"
- "//tests/contrib:test_id_compare_ids_test"
- "//tests/docker/package_managers:test_download_pkgs_docker_cp"
- "//tests/docker/package_managers:test_download_pkgs_docker_run"
- "//tests/docker/package_managers:test_download_pkgs_rule"
- "//tests/docker/package_managers:test_install_pkgs_rule"
- "//tests/docker/util:test_container_commit_rule"
- "//tests/docker/util:test_container_extract_rule"
- "//tests/docker/util:test_extract_script"
- "//tests/docker/util:test_container_commit_layer_rule"
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
- //basic:all
- //extended:all
- //java_app:all
- //run_instruction_apt_pkgs:all
- //run_instruction_arbitrary:all
test_flags:
- "--action_env=PATH"
- "--test_output=errors"
# Needed because register_platforms is apparently not respecting order of
# platforms passed:
- "--extra_execution_platforms=@local_config_platform//:host,@io_bazel_rules_docker//platforms:local_container_platform"
rbe_ubuntu1604:
- --config=bezel
- --test_output=errors
testing_java_image:
platform: ubuntu1804
working_directory: testing/java_image
shell_commands:
- cp ../../.bazelrc .
build_targets:
- "--"
- "..."
# tests/docker/security require gcloud setup to access asci-toolchains images
- "-//tests/docker/security/..."
# contrib targets are not compatible with remote exec
- "-//tests/contrib:derivative_with_volume_repro_test"
- "-//tests/contrib:random_file_img_non_repro_test"
- "-//tests/contrib:rbe-test-xenial_repro_test"
- "-//tests/contrib:set_cmd_repro_test"
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
- //...
build_flags:
- "--extra_toolchains=@buildkite_config//config:cc-toolchain,//toolchains:rbe_container_cc_toolchain"
- "--extra_execution_platforms=@buildkite_config//config:platform,//platforms:rbe_container_platform"
- "--host_platform=@buildkite_config//config:platform"
- "--platforms=@buildkite_config//config:platform"
- "--keep_going"
# For tests/container:set_env_make_vars
- "--define=ENV_KEY=my_key"
- "--define=ENV_VALUE=my_value"
- --config=bezel
testing_download_pkgs_at_root:
platform: ubuntu1804
working_directory: testing/download_pkgs_at_root
shell_commands:
- cp ../../.bazelrc .
test_targets:
- //...
test_flags:
- --config=bezel
- --test_output=errors
testing_custom_toolchain_flags:
platform: ubuntu1804
working_directory: testing/custom_toolchain_flags
shell_commands:
- cp ../../.bazelrc .
test_targets:
- "--"
- "//:structure_test_at_workspace_root"
- "//tests/..."
# tests/docker/security require gcloud setup to access asci-toolchains images
- "-//tests/docker/security/..."
# contrib tests are not compatible with remote exec
- "-//tests/contrib:derivative_with_volume_repro_test"
- "-//tests/contrib:random_file_img_non_repro_test"
- "-//tests/contrib:rbe-test-xenial_repro_test"
- "-//tests/contrib:set_cmd_repro_test"
- "-//tests/contrib:test_compare_ids_test_diff_ids_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails"
- "-//tests/contrib:test_compare_ids_test_invalid_tar_fails_multi_regex"
- "-//tests/contrib:test_compare_ids_test_no_images_with_id_fails"
- "-//tests/contrib:test_compare_ids_test_one_tar_no_id_fails"
- "-//tests/contrib:test_compare_ids_test_wrong_id_fails"
# Disabled e2e tests that pull from localhost in nested workspace
- "-//testing/new_pusher_tests/..."
# Disable the configs_test targets for automatic container release tests on
# RBE as the RBE bots don't have the necessary permissions to pull the
# checker images.
- "-//tests/contrib/automatic_container_release:configs_test"
- "-//tests/contrib/automatic_container_release:configs_test_deps_spec_only"
- //...
test_flags:
- "--extra_toolchains=@buildkite_config//config:cc-toolchain,//toolchains:rbe_container_cc_toolchain"
- "--extra_execution_platforms=@buildkite_config//config:platform,//platforms:rbe_container_platform"
- "--host_platform=@buildkite_config//config:platform"
- "--platforms=@buildkite_config//config:platform"
- "--keep_going"
# For tests/container:set_env_make_vars_test
- "--define=ENV_KEY=my_key"
- "--define=ENV_VALUE=my_value"
- "--test_output=errors"
- --config=bezel
- --test_output=errors
17 changes: 17 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,20 @@ test:remote --google_default_credentials=true

test:remote --remote_timeout=3600
test:remote --keep_going

# Experimental send build results to bzl.io
build:bezel --bes_backend=grpcs://api.bzl.io:443
build:bezel --bes_results_url=https://bzl.io/pipeline
build:bezel --bes_timeout=5s
build:bezel --build_event_publish_all_actions

# Configuration specific to github actions test runner.
test:github --test_output=errors --verbose_failures
test:github --config=bezel

# Configuration specific to buildkite CI testing the default workspace
test:buildkite_default --config=bezel
test:buildkite_default --action_env=PATH
test:buildkite_default --define=ENV_KEY=my_key # for tests/container:set_env_make_vars_test
test:buildkite_default --define=ENV_VALUE=my_value # for tests/container:set_env_make_vars_test
test:buildkite_default --test_output=errors
11 changes: 0 additions & 11 deletions .github/workflows/size-label.yml

This file was deleted.

34 changes: 0 additions & 34 deletions .travis.yml

This file was deleted.

4 changes: 2 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ http_file(

http_file(
name = "launchpad_openjdk_gpg",
sha256 = "32e2f5ceda14f8929d189f66efe6aa98c77e7f7e4e728b35973e7239f2456017",
urls = ["http://keyserver.ubuntu.com/pks/lookup?op=get&fingerprint=on&search=0xEB9B1D8886F44E2A"],
sha256 = "e9a596d0c194a562be9fd2c2a0994d7885505a1145fed0fbd5ae4c11d56220a0",
urls = ["https://keyserver.ubuntu.com/pks/lookup?op=get&fingerprint=on&search=0xEB9B1D8886F44E2A"],
)

container_load(
Expand Down
Loading