Fixed broken //tests/docker/util:all tests
#1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
changed the title
//tests/docker/util:all tests//tests/docker/util:all tests
UebelAndre
changed the title
//tests/docker/util:all tests//tests/docker/util:all tests
UebelAndre
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
alexeagle
reviewed
Apr 25, 2021
container/layer_tools.bzl
Outdated
| @@ -120,8 +120,10 @@ def get_from_target(ctx, name, attr_target, file_target = None): | |||
| else: | |||
| if not hasattr(attr_target, "files"): | |||
| return {} | |||
| target = attr_target.files.to_list()[0] | |||
| return _extract_layers(ctx, name, target) | |||
| tar_files = [file for file in attr_target.files.to_list() if file.extension == "tar"] | |||
There was a problem hiding this comment.
so the bug was the toolchain was giving us more than one file?
There was a problem hiding this comment.
The rule_test was providing the files listed in generates. The issue was that this code assumed that there was either one file or that the first file is a tar file. So the fix I went with was to search for tar files and require that only one was found.
There was a problem hiding this comment.
The issue originates from
rules_docker/tests/docker/util/BUILD
Lines 82 to 85 in 0adf8b2
alexeagle
reviewed
Apr 25, 2021
|
Oh so the bug was actually that we sorted that list? |
alexeagle
approved these changes
Apr 25, 2021
martaver
pushed a commit
to cleric-sh/rules_docker
that referenced
this pull request
May 18, 2021
* Fix broken `//tests/docker/util:all` tests * just revert the breaking reordering change Co-authored-by: Alex Eagle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
RBE builds are currently failing when testing
//tests/docker/util:allwith the following errorWhat is the new behavior?
This PR introduces the fix for this.
Does this PR introduce a breaking change?
Other information