Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: more containers stardoc stuff #1835

Closed
wants to merge 1 commit into from

Conversation

zoidyzoidzoid
Copy link
Contributor

@zoidyzoidzoid zoidyzoidzoid commented Apr 29, 2021

TODO: the difficult part of making sure macros / attrs have the accurate docs from the README and we're only exporting docs for the useful rules

Follow up of #1832

TODO: the difficult part of making sure macros / attrs have the accurate docs from the README
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@alexeagle
Copy link
Contributor

Let's keep doing just one at a time? Otherwise it's overwhelming to look through the diffs.

https://github.com/bazelbuild/rules_docker#container_bundle-1
has docs for images and has a rule docstring but
https://github.com/bazelbuild/rules_docker/blob/12e0f2a8fb32e702ad1dd99490179cca38c1eb96/docs/bundle.md
doesn't, for example.

@alexeagle
Copy link
Contributor

Hi, still have any time for this? Can I help get it unstuck? I'm keen to finish migrating the docs to stardoc (just approved a PR that makes manual readme changes which are out-of-date from the code :(

@alexeagle
Copy link
Contributor

I think I replaced this with 454981e

@alexeagle alexeagle closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants