Add tool target attribute to docker toolchain #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
moshe
force-pushed
the
moshe.add-tool-target-attribute-to-docker-toolchain
branch
from
4471bb7 to
863a3f8
Compare
alexeagle
force-pushed
the
moshe.add-tool-target-attribute-to-docker-toolchain
branch
from
863a3f8 to
6b716a3
Compare
|
I rebased it to get past a suppression of broken test |
Thank you @alexeagle! ETA for a review? |
alexeagle
approved these changes
Dec 6, 2021
gravypod
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Regarding 👇, do you have docs about how to add tests and how to generate docs?
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there is no way to supply a docker client as a target, which requires you to install docker not part of Bazel
What is the new behavior?
Just like the other tools in the toolchain (gzip, xz), you can supply
docker_targetin order to get the docker client from bazelDoes this PR introduce a breaking change?