Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Disable some //test/container tests in Mac #1952

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

gravypod
Copy link
Collaborator

@gravypod gravypod commented Nov 7, 2021

Not sure why this started failing. I'll investigate sometime in the future when I have access to MacOS hardware.

@gravypod gravypod requested a review from alexeagle November 7, 2021 15:06
@google-cla google-cla bot added the cla: yes label Nov 7, 2021
@gravypod gravypod force-pushed the disable-alpine-custom-attr-test branch 3 times, most recently from a9fad62 to 8b7718f Compare November 7, 2021 20:29
Not sure why this started failing. I'll investigate sometime in the
future when I have access to MacOS hardware.
@gravypod gravypod force-pushed the disable-alpine-custom-attr-test branch from 8b7718f to 0168e8f Compare November 7, 2021 20:34
@gravypod gravypod changed the title Temporarily disable //t/c:alpine_custom_attr_digest_test on MacOS Temporarily Disable some //test/container tests in Mac Nov 7, 2021
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the best we can do with the resources we have. Can't leave PRs red.

@gravypod gravypod merged commit a351a3f into master Nov 7, 2021
@gravypod gravypod deleted the disable-alpine-custom-attr-test branch November 7, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants