chore: enable incompatible_disable_depset_items #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
i1939
branch
4 times, most recently
from
cc82a7b to
ade0ae9
Compare
gravypod
approved these changes
Dec 13, 2021
| @@ -85,6 +86,8 @@ def _impl(ctx, image_tar = None, packages = None, additional_repos = None, outpu | |||
| output_script: File, overrides ctx.outputs.build_script | |||
| output_metadata: File, overrides ctx.outputs.metadata_csv | |||
| """ | |||
| if types.is_depset(packages): | |||
There was a problem hiding this comment.
Does this check work without --incompatible_disable_depset_items?
There was a problem hiding this comment.
I guess this should work? /cc @alexeagle
There was a problem hiding this comment.
yes, this only depends on bazel-skylib
|
I'll just remove it from the .bazelrc file to fix rules_docker with Bazel@HEAD: |
meteorcloudy
added a commit
that referenced
this pull request
Dec 21, 2021
`--incompatible_disable_depset_items` is removed at Bazel@HEAD and is turned on by default in 5.0. See #1977 (comment)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1939