Support credential helpers in container_pull #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
requested review from
smukherj1,
alexeagle,
pcj and
gravypod
as code owners
uhthomas
reviewed
Apr 19, 2022
container/pull.bzl
Outdated
| @@ -64,6 +64,13 @@ _container_pull_attrs = { | |||
| """, | |||
| mandatory = False, | |||
| ), | |||
| "cred_helpers": attr.label_list( | |||
| doc = """Labels to a list of credential helpers binaries that are configured in `docker_client_config`. | |||
There was a problem hiding this comment.
nit:
-helpers binaries
+helper binaries
|
Changes look great, thanks! This will be useful for our organisation also :) |
uhthomas
approved these changes
Apr 19, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, all credential helpers are required to be in system
PATHbefore callingcontainer_pullwith authentication. This is not portable.Issue Number: N/A
What is the new behavior?
toolchain_configandcontainer_pullcan take a list of credential helpers as labels, so we can check them into a repository, without installing them on the system or setting systemPATHDoes this PR introduce a breaking change?
Other information