Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip packages specified with brackets fail #26

Closed
timblakely opened this issue Oct 9, 2017 · 4 comments
Closed

Pip packages specified with brackets fail #26

timblakely opened this issue Oct 9, 2017 · 4 comments

Comments

@timblakely
Copy link

timblakely commented Oct 9, 2017 •
edited
Loading

gapic-google-cloud-datastore depends on googleapis-common-protos[grpc] and proto-google-cloud-datastore-v1[grpc]. I believe pip canonically drops these extra bracketed tags, but the requirement function attempts to look it up in _requirements by the full key which fails.
@mattmoor
Copy link
Contributor

mattmoor commented Oct 9, 2017

Does this fix it for you? #18

@mattmoor
Copy link
Contributor

Here's the issue tracking "extras" support: #12 I'm going to resolve in favor of that.

@timblakely
Copy link
Author

Thanks, yup, should resolve it.

@mattmoor
Copy link
Contributor

There may be other issues with the google libraries (there is another open issue), but I'm hoping that at least the first-level issue is resolved by my PR :-/

alexeagle pushed a commit to alexeagle/rules_python that referenced this issue Aug 19, 2020
@dillon-giacoppo
Merge pull request bazelbuild#26 from dillon-giacoppo/dillon-format-a…
b981944 
…nd-lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmoor @timblakely