Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gazelle): use relative paths for resolved imports #1554

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

adzenith
Copy link
Contributor

@adzenith adzenith commented Nov 10, 2023

Modify the Gazelle plugin so that when it adds a dep because of a resolve directive it makes it a relative import if possible.

The first commit adds a test for the existing behavior, where inside of //package2 the dependency //package2:resolved_package is added. The second commit updates the test and the behavior so inside of //package2 we add :resolved_package instead.

Copy link

google-cla bot commented Nov 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adzenith adzenith force-pushed the relative-resolved-imports branch from 6399440 to fbbc91b Compare November 10, 2023 20:47
@aignas aignas enabled auto-merge November 13, 2023 13:09
@aignas aignas added this pull request to the merge queue Nov 13, 2023
Merged via the queue into bazelbuild:main with commit a9032d2 Nov 13, 2023
@adzenith adzenith deleted the relative-resolved-imports branch November 13, 2023 16:51
@adzenith
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants