Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow piptool to build wheels. #32

Merged
merged 4 commits into from
Nov 15, 2017
Merged

Allow piptool to build wheels. #32

merged 4 commits into from
Nov 15, 2017

Conversation

duggelz
Copy link

@duggelz duggelz commented Nov 10, 2017 •
edited
Loading

Fixes #17

Depends on google/subpar#52

@duggelz duggelz requested a review from mattmoor November 10, 2017 20:08
mattmoor
mattmoor approved these changes Nov 11, 2017
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you hint at this in your PR message, but just to make sure I understand what's left, we still need to:

  1. Update WORKSPACE to point to the new google/subpar commit.
  2. Run ./update_tools.sh

Can we also add a little test that currently fails (at least on OSX) building the bdist_wheel?

Otherwise, just one minor nit. LGTM

rules_python/piptool.py Outdated
import wheel

# Make sure we're using a suitable version of pip as a library.
# Fallback on using it as a CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@duggelz
Copy link
Author

duggelz commented Nov 13, 2017 •
edited
Loading

In separate changes, I will:

  • Update WORKSPACE to point to the google/subpar 1.1.0 tag that I just created.
  • Run ./update_tools.sh
  • Add a set of virtualenv-based tests that construct environments with and without various packages of note: pip, wheel, setuptools

@duggelz duggelz merged commit e003509 into master Nov 15, 2017
@duggelz duggelz deleted the dgreiman/issue17 branch November 15, 2017 22:05
@ben-ng ben-ng mentioned this pull request Nov 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duggelz @mattmoor @googlebot