Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-719 - Live Page UX: Update column width on large screen size #11105

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Sep 28, 2023

Resolves WSTEAM1-719 - Update column width on large screen size

Overall changes

Update UX for Live Page. Reduce 'stream' column width on larger screen sizes to match designs. Notably, to reduce the size that images render at.

Before (without this PR)
Screenshot 2023-09-28 at 15 52 59

After (with this PR)
Screenshot 2023-09-28 at 15 53 25

With Grid
Screenshot 2023-09-28 at 15 53 43

Design
Screenshot 2023-09-28 at 13 54 15

Code changes

  • Change grid-column on Group_5_min_width screen sizes (1280 px and larger)
  • Update snapshot

Testing

Go to the Storybook permalink.
Compare to the current page on test

Helpful Links

UX Designs

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review September 28, 2023 15:07
@HarveyPeachey HarveyPeachey changed the title Live Page UX: Update column width on large screen size WSTEAM1-719 - Live Page UX: Update column width on large screen size Dec 1, 2023
Copy link
Contributor

@HarveyPeachey HarveyPeachey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further work required, just pending a UX design clarification https://bbc-tpg.slack.com/archives/C03RXS2EH3K/p1701424227556449

@HarveyPeachey HarveyPeachey merged commit 1204572 into latest Dec 5, 2023
@HarveyPeachey HarveyPeachey deleted the live-page-columns branch December 5, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants