WSTEAM1-623: Render VJ Embeds on .AMP #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isabella-Mitchell
changed the title
|
|
||
| if (isAmp) { | ||
| if (isVDJEmbed) { | ||
| if (parameters) { |
There was a problem hiding this comment.
I've included this so that we don't render nothing at the URL http://localhost:7080/pidgin/articles/c0nzj66vp65o.amp?renderer_env=test
An alternative would be to have if (!parameters) return null. As I understand parameters will always be supplied. soo we could potentially remove this once the BFF changes are merged in.
…s for local testing
amoore108
reviewed
Oct 30, 2023
amoore108
reviewed
Oct 30, 2023
amoore108
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves WSTEAM1-677: Render VJ embed on .amp
(Subtask of WSTEAM1-623: Embeds: Optimo VJ interactives embeds .amp)
Overall changes
Render VJ embeds on .amp for Optimo articles. Migrate legacy
VjAmpcontainer logic to newAmpIframecomponent which uses our new component standards.Code changes
data/...
aresTypetooEmbedin Riddle and Flourish fixture data. (Also update Riddle/Flourish articles to latest BFF output to check for any other changes.)AmpIframe/...
containers/include/amp/VJAmpEmbeds/...
AmpIframeEmbedto handle VJ .amp embedsrc/app/components/Embeds/OEmbed/index.tsxto render AmpIframeEmbed componentLegacy/containers/include/...
VjAmpcomponentTesting
Pull down this PR and run Simorgh locally
Visit http://localhost:7080/pidgin/articles/c578zj113e9o.amp and see VJ embed asset
Visit http://localhost:7080/pidgin/articles/cqwq7dm61zeo.amp and see error message (Flourish)
Visit http://localhost:7080/pidgin/articles/c39rjygpmv1o.amp and see error message (Riddle)
Visit http://localhost:7080/ukrainian/news-russian-23333960.amp and see VJ embed asset (Story page VJ embed)
Before BFF changes are merged in:
Visit http://localhost:7080/pidgin/articles/c0nzj66vp65o.amp?renderer_env=test to see the error message (as no params are supplied)
After BFF changes are merged in:
Visit http://localhost:7080/pidgin/articles/c0nzj66vp65o.amp?renderer_env=test and see VJ embed asset
Helpful Links
Add Links to useful resources related to this PR if applicable.
UX Specs
Coding Standards
Repository use guidelines