WSTEAM1-700: Display media on Live Page #11198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simorgh into WSTEAM1-641-display-media-live-page
alex-magana
changed the title
amoore108
reviewed
Dec 1, 2023
amoore108
reviewed
Dec 1, 2023
…simorgh into WSTEAM1-641-display-media-live-page
amoore108
reviewed
Dec 4, 2023
Comment on lines
+4
to
+10
| const getPlayerProps = ({ pageType, ...params }) => { | ||
| const propsHandler = { | ||
| live: getLivePageProps, | ||
| }[pageType]; | ||
|
|
||
| return propsHandler ? propsHandler(params) : getDefaultProps(params); | ||
| }; |
There was a problem hiding this comment.
Quite like this approach. Should set us up well for building out the Media player in Simorgh later 👍
amoore108
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Looks great 👍
Think its worth commenting for other reviewers that we are going to be replacing the MediaPlayer component, starting with Live pages, in the new year, so we don't really need to Typescript-ify, apply component standards etc just yet. Its just a copy of the existing ArticleMediaPlayer component to get it on the page and will be replaced in the near future.
shayneahchoon
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA [WSTEAM1-700]
Overall changes
Adds support for rendering video on a Live Page post
Code changes
componentsToRendermapping.Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines