WSTEAMA-901: Render /persian/afghanistan as a topic page on local & test environments #11221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age on local & test environments""
pvaliani
reviewed
Dec 8, 2023
| const path = [topicPath]; | ||
|
|
||
| if (!isLive()) { | ||
| path.push('/persian/afghanistan'); |
There was a problem hiding this comment.
Will leave it optional but based on @amoore108's feedback yday we could also do something like
const path = [topicPath, !isLive() && '/persian/afghanistan'].filter(Boolean);
as an alternative if you find this more readable.
There was a problem hiding this comment.
Thanks for that @pvaliani. Given that we're going to have to change this again next week, when we put /persian/afghanistan live (and we'll remove all isLive() logic), are you happy for us to leave it as is for now? (But I'll be bookmarking this comment so that I remember how to do this another time 😸 )
There was a problem hiding this comment.
Oh aye, it's totally down to preference! Go for it
pvaliani
approved these changes
Dec 8, 2023
karinathomasbbc
deleted the
revert-11220-revert-11196-persian-afghanistan-topicpage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAMA-901
Overall changes
Renders /persian/afghanistan as a topic page
Code changes
Testing
See ticket for testing information
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines