Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To manage all the optional dependencies and related code, Simple Java Mail should be split up into modules #183

Closed
bbottema opened this issue Nov 24, 2018 · 5 comments
Closed

To manage all the optional dependencies and related code, Simple Java Mail should be split up into modules #183

bbottema opened this issue Nov 24, 2018 · 5 comments
Assignees
@bbottema
Labels
major feature Priority-Low
Milestone
6.0.0-rc1

Comments

@bbottema
Copy link
Owner

bbottema commented Nov 24, 2018 •
edited
Loading

Currently the single main project Simple Java Mail contains all the code and optional dependencies. To better manage the code and dependencies and more clearly communicate these options to our users, Simple Java Mail should be split up into modules.

This could also solve all the cyclic dependencies between the modules and the main project.
@bbottema bbottema self-assigned this Nov 24, 2018
@bbottema bbottema added this to the 6.0.0 milestone Nov 24, 2018
@bbottema bbottema mentioned this issue Nov 24, 2018
Closed
bbottema added a commit that referenced this issue Dec 1, 2018
@bbottema
#183: implementing central module-loading, but unfortunately, splitti…
dc3fff8 
…ng the project up in actual modules proved infeasible. Next best thing is to work with dependency modules, which just import the right dependencies for users, without actually splitting up dependant code
bbottema added a commit that referenced this issue Jan 12, 2019
@bbottema
#183: Update badges
8707b05
@bbottema
Copy link
Owner Author

bbottema commented Jan 12, 2019 •
edited
Loading

Ugh, code coverage with Code Climate, Codacy or Coveralls seems impossible with GIT submodules. Now it seems I broke the Codacy project board as well :/

edit 02-02-2019: files a ticket with Codacy to have the boards fixen...

bbottema added a commit that referenced this issue Jan 31, 2019
@bbottema
- moved all modularized code into their own modules and fixed depende…
cb5ce64 
…ncy issues (#183),

- restructured all packages (#183),
- added support for CalendarMethod in CLI (#156),
- fixed JavaDoc for Maven multi-module project (#183)
- fixed all JavaDoc problems (#156)
bbottema added a commit that referenced this issue Feb 2, 2019
@bbottema
#183: fixed Codacy projects and badges for all modules
ae8e8c8
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: step one of reintegrating all GIT modules into the main repo
c4b9a8a
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: step two of reintegrating all GIT modules into the main repo
453152f
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed spring-module pom, since it does produce a jar
b860880
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed relativePath property
d3276c0
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed Jacoco aggregated coverage report
7d97238
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Reintegrate coverage data in Codacy
d564b89
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed references to Travis and Codacy
c9b85f9
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed coverage report hopefully
ead848d
bbottema added a commit that referenced this issue Feb 3, 2019
@bbottema
#183: Fixed coverage report hopefully
e423b13
@bbottema
Copy link
Owner Author

bbottema commented Feb 3, 2019 •
edited
Loading

The project has been split up in multiple modules now, using Maven submodules.

Everything was split up in GIT module repo's as well and although it worked okay-ish, in hindsight there aren't any good reasons to keep this approach. Some things don't work as well and really it doesn't make the project easier to understand to other people.

The following Maven projects now exist in repo:

Next tasks:

  1. Fix build & deploy scripts
  2. Update documentation to reflect module structure
  3. * Have the aggregated Javadoc artifact be available on javadoc.io
  4. Move how-to-release, RELEASE etc. from the simple-java-mail module to the parent project
  5. * Update README.MD to point to the main javadoc site
  6. Update README.MD to point to the Travis build
  7. Re-add coverage report in Codacy
  8. Fix CLI stand-alone artifact

*) Javadoc site only starts existing after the library has been published to Maven Central.

bbottema added a commit that referenced this issue Feb 4, 2019
@bbottema
#183: Fixed references to parent pom versions and now producing aggre…
b95fc6c 
…gated javadoc jar
bbottema added a commit that referenced this issue Feb 5, 2019
@bbottema
#183: Fixed aggregator Maven project name
b23ceb1
bbottema added a commit that referenced this issue Feb 5, 2019
@bbottema
#183: Moved Cli static void main support to Cli Module and removed Cl…
34c1318 
…i module loading from Simple Java Mail main module, since CLI is a layer on top of Simple Java Mail
bbottema added a commit that referenced this issue Feb 5, 2019
@bbottema
#183: Removed obsolete README files
44ca510
bbottema added a commit that referenced this issue Feb 5, 2019
@bbottema
#183: Added FIXME for later
30765cd
bbottema added a commit that referenced this issue Feb 8, 2019
@bbottema
#183: *All* modules should include an ApacheV2 license file
fa66085
bbottema added a commit that referenced this issue Feb 8, 2019
@bbottema
#183: Master project is not meant for 3rd party use, so don't include…
372ad1c 
… a NOTICE file
bbottema added a commit that referenced this issue Feb 8, 2019
@bbottema
#156, #183: Fixed CLI stand-alone executable program in multi-module …
ea57c7e 
…project
bbottema added a commit that referenced this issue Feb 8, 2019
@bbottema
#183: Fix module versioning so that it installs properly in maven rep…
423b836 
…o and can actually be used by other projects
bbottema added a commit that referenced this issue Feb 9, 2019
@bbottema
#183: Switched back to separate GIT module for the angular-app, so we…
6ec4655 
… can configure a dedicated CI/CD build pipeline
bbottema added a commit that referenced this issue Feb 9, 2019
@bbottema
#183: Switched back to separate GIT module for the angular-app, so we…
bb57e9a 
… can configure a dedicated CI/CD build pipeline
bbottema added a commit that referenced this issue Feb 12, 2019
@bbottema
#183: Removed crutch for managing versions, now that we have a better…
7676c01 
… way to automate version management in CI/CD pipline using the buildhelper built in maven plugin
bbottema added a commit that referenced this issue Mar 31, 2019
@bbottema
#183: Fixed multi module releases
c2f2a91
@bbottema
Copy link
Owner Author

bbottema commented Apr 1, 2019

Regarding multi modules, everything is ready for deploy to Maven Central. After deploying 6.0.0 we can fix links to the right Javadoc site.

@bbottema bbottema closed this as completed Apr 1, 2019
@bbottema
Copy link
Owner Author

Released in 6.0.0-rc1!

@bbottema
Copy link
Owner Author

6.0.0 has released as well, finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
major feature Priority-Low
Projects
None yet
Milestone
6.0.0-rc1
Development

No branches or pull requests
1 participant
@bbottema