Fix several C errors #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rprintf` cannot have a non-literal as its first argument; this used to work simply because compiler diagnostics were not good enough, but some R configurations compile with `-Werror=format-security`, and this code then causes an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rprintfcannot have a non-literal as its first argument; this used to work simply because compiler diagnostics were not good enough, but some R configurations compile with-Werror=format-security, and this code then causes an error.[v]sprintfis blocked byFORTIFY_SOURCE. Fixing it should be as easy as replacing the relevant calls by[v]snprintf./cc @banfai