Fix more C warnings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some other warnings that were missed in the previous MR. This one is more exhaustive, and builds cleanly for me locally. However, it changes the public signature of the exported AVL tree functions, and as a consequence it might break downstream dependencies. I had a look through the other ribios* packages but I couldn’t find any that used the AVL tree implemeentation. Still, we might want to exercise caution before merging this change.
Apparently `%T` is still not supported by all standard library versions (in particular MinGW), despite being a POSIX standard. We can fix this easily by instead using `%H:%M:%S`.
|
Thanks a lot, daer @klmr. I confirm that the AVL tree implementation is not actively used in other ribios packages. The data structure was introduced by Clemens Broger in the BIOS package for the hash_table, which has not been exposed to R by ribios packages. I reviewed the changes and they look fantastic. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some other warnings that were missed in the previous MR. This one is more exhaustive, and builds cleanly for me locally (with many warnings enabled). However, it changes the public signature of the exported AVL tree functions, and as a consequence it might break downstream dependencies. I had a look through the other ribios* packages but I couldn’t find any that used the AVL tree implementation. Still, we might want to exercise caution before merging this change.