This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Drag drop fix #115
Merged
Drag drop fix #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floating or not is now split into separate plugins
|
@colinfrei seems like there is a trivial formatting issue in the patch: http://travis-ci.org/#!/bergie/hallo/builds/2569431/L169 |
|
Adjusted line length, http://www.coffeelint.org/ says it's ok now. |
|
@colinfrei thanks! At some point we need to figure out how to simulate user interaction so we can add tests for the image stuff... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're finally using create, hallo and some of the cmf bundles in a client project, and this is some cleanup to make the image drag/drop work better/work again, as well as some other cleanup.