Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using as ESP IDF component #131

Merged
merged 5 commits into from
Dec 17, 2023
Merged

Support using as ESP IDF component #131

merged 5 commits into from
Dec 17, 2023

Conversation

dzungpv
Copy link
Contributor

@dzungpv dzungpv commented Dec 15, 2023

Support using as ESP IDF component by rename String and IPAddress class.

@dzungpv
Copy link
Contributor Author

dzungpv commented Dec 15, 2023

I am using your lib here: https://github.com/dzungpv/mitsubishi2MQTT

@bertmelis
Copy link
Owner

Nice.

It is still on my todo list to start using Arduino as a component so I can tune ESP-IDF to my liking. One step closer...

One remark with this PR: the filename IPAddressTest I don't like. Maybe ClientPosixIPAddress. It's a tad longer but the two belong together.

@dzungpv
Copy link
Contributor Author

dzungpv commented Dec 15, 2023

Nice.

It is still on my todo list to start using Arduino as a component so I can tune ESP-IDF to my liking. One step closer...

One remark with this PR: the filename IPAddressTest I don't like. Maybe ClientPosixIPAddress. It's a tad longer but the two belong together.

You can change it name, Now I just quick fix for release my project.

@bertmelis bertmelis merged commit ee8adb9 into bertmelis:main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants