This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Adding the ability to append query strings to the on jdbc urls #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability to append query strings to the end of a jdbc url
Fixed rubocop errors
|
Fixed the rubocop errors. Is there any way to start a new build? |
ghost
mentioned this pull request
linc01n
added a commit
that referenced
this pull request
Jul 25, 2016
linc01n
added a commit
that referenced
this pull request
Jul 25, 2016
Adding the ability to append query strings to the end of a jdbc url
|
Thanks for the pull request. I have merged it to master. I made a few changes due to conflict, missing test and data-bag handling. Line 26 in eadae43 chef-stash/spec/database_spec.rb Line 34 in eadae43 chef-stash/spec/database_spec.rb Line 80 in eadae43 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a feature request, issue #159. This creates a new attribute in the name space ['stash']['database']['query_string'] where the attribute is a string. The string is appended to the end of the jdbc url for things like encrypting the connection to the database via SSL. The feature is for postgresql, mysql, and sqlserver. The default value for the attribute is an empty string.