Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar quality gate #357

Merged
merged 1 commit into from
May 20, 2024
Merged

Sonar quality gate #357

merged 1 commit into from
May 20, 2024

Conversation

alkoleft
Copy link
Member

@alkoleft alkoleft commented May 20, 2024 •
edited
Loading

Формирование аннотаций по замечаниям сонара

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited
Loading

SonarQube Code Analytics

Quality Gate passed

passed

Additional information

The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.

Issues

bug 0 Bugs

vulnerability 0 Vulnerabilities

code_smell 0 Code Smells

Coverage and Duplications

No data Coverage

No data Duplication

@alkoleft alkoleft force-pushed the sonar-quality-gate branch from ec0487e to 7209041 Compare May 20, 2024 16:41
github-actions[bot]
github-actions bot reviewed May 20, 2024
View reviewed changes
exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
@@ -211,8 +209,29 @@

КонецФункции

// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on
Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо избавиться от многократного использования строкового литерала "_!%*" Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 1min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
@@ -211,8 +209,29 @@

КонецФункции

// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on
Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество необязательных параметров c 10 до допустимого 3 Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 30min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
@@ -211,8 +209,29 @@

КонецФункции

// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on
Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество параметров c 10 до допустимого 7 Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 30min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
@@ -211,8 +209,29 @@

КонецФункции

// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on
Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавьте описание метода программного интерфейса Why is this an issue?

CODE_SMELL Codesmell　　INFO Info　　:hourglass: 1min effort

github-actions[bot]
github-actions bot reviewed May 20, 2024
View reviewed changes
exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on

Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо избавиться от многократного использования строкового литерала "_!%*" Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 1min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on

Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество необязательных параметров c 10 до допустимого 3 Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 30min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on

Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество параметров c 10 до допустимого 7 Why is this an issue?

CODE_SMELL Codesmell　　MINOR Minor　　:hourglass: 30min effort

exts/yaxunit/src/CommonModules/Мокито/Module.bsl Outdated
// BSLLS:NumberOfParams-on
// BSLLS:NumberOfOptionalParams-on

Функция МассивПараметров2(Параметр1 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавьте описание метода программного интерфейса Why is this an issue?

CODE_SMELL Codesmell　　INFO Info　　:hourglass: 1min effort

@alkoleft alkoleft force-pushed the sonar-quality-gate branch from bd9b718 to 7efb38a Compare May 20, 2024 19:02
@alkoleft alkoleft added the ci/cd Сборочная линия движка label May 20, 2024
@alkoleft alkoleft merged commit 36f71d7 into develop May 20, 2024
2 of 3 checks passed
@alkoleft alkoleft deleted the sonar-quality-gate branch May 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
ci/cd Сборочная линия движка
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alkoleft