Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

288 / Проброс параметров по умолчанию #362

Merged
merged 3 commits into from
May 27, 2024

Conversation

alkoleft
Copy link
Member

@alkoleft alkoleft commented May 27, 2024

Описание изменений

Проброс параметров по умолчанию

  • При вызове методов при проверке утверждений
  • При обучении мокито

  • Добавлены тесты
  • Изменения отражены в документации (при необходимости)

Close #288

При вызове метода и при настройке мокито
Если Не ДобавитьНеПоследнее(Значения, Значение10) Тогда
Возврат Значения;
КонецЕсли;
Функция ЗначениеВМассиве(Значение1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество необязательных параметров c 9 до допустимого 3 Why is this an issue?

CODE_SMELL Codesmell  MINOR Minor  :hourglass: 30min effort

Если Не ДобавитьНеПоследнее(Значения, Значение10) Тогда
Возврат Значения;
КонецЕсли;
Функция ЗначениеВМассиве(Значение1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавьте описание возвращаемого значения функции Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Если Не ДобавитьНеПоследнее(Значения, Значение10) Тогда
Возврат Значения;
КонецЕсли;
Функция ЗначениеВМассиве(Значение1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уменьшите количество параметров c 10 до допустимого 7 Why is this an issue?

CODE_SMELL Codesmell  MINOR Minor  :hourglass: 30min effort

Возврат Значения;
КонецЕсли;
Функция ЗначениеВМассиве(Значение1,
Значение2 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо избавиться от многократного использования строкового литерала "_!%*" Why is this an issue?

CODE_SMELL Codesmell  MINOR Minor  :hourglass: 1min effort

ФлагПустогоЗначения = "_!%*";
Значения = Неопределено;

Для Инд = -10 По -1 Цикл
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Справа от '-' не хватает пробела Why is this an issue?

CODE_SMELL Codesmell  INFO Info  :hourglass: 1min effort

Значение4 = "_!%*",
Значение5 = "_!%*",
Значение6 = "_!%*",
Значение7 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение7" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение5 = "_!%*",
Значение6 = "_!%*",
Значение7 = "_!%*",
Значение8 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение8" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение6 = "_!%*",
Значение7 = "_!%*",
Значение8 = "_!%*",
Значение9 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение9" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

ФлагПустогоЗначения = "_!%*";
Значения = Неопределено;

Для Инд = -10 По -1 Цикл
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Справа от '-' не хватает пробела Why is this an issue?

CODE_SMELL Codesmell  INFO Info  :hourglass: 1min effort

Значение = ЗначениеПоУмолчанию;
КонецЕсли;

Значения[-Инд - 1] = Значение;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слева от '-' не хватает пробела Why is this an issue?

CODE_SMELL Codesmell  INFO Info  :hourglass: 1min effort

Copy link
Contributor

github-actions bot commented May 27, 2024

SonarQube Code Analytics

Quality Gate passed

passed

Additional information

The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.

Issues

bug 0 Bugs

vulnerability 0 Vulnerabilities

code_smell 0 Code Smells

Coverage and Duplications

No data Coverage

duplication_lt_3 0.00% Duplication

Значения = Новый Массив(- Инд);
КонецЕсли;

Значения[- Инд - 1] = Значение;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слева от '-' не хватает пробела Why is this an issue?

CODE_SMELL Codesmell  INFO Info  :hourglass: 1min effort

// BSLLS:DuplicateStringLiteral-off
Функция ЗначениеВМассивеПоУмолчанию(ЗначениеПоУмолчанию,
Значение1,
Значение2 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение2" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Функция ЗначениеВМассивеПоУмолчанию(ЗначениеПоУмолчанию,
Значение1,
Значение2 = "_!%*",
Значение3 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение3" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение1,
Значение2 = "_!%*",
Значение3 = "_!%*",
Значение4 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение4" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение2 = "_!%*",
Значение3 = "_!%*",
Значение4 = "_!%*",
Значение5 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение5" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение3 = "_!%*",
Значение4 = "_!%*",
Значение5 = "_!%*",
Значение6 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение6" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение4 = "_!%*",
Значение5 = "_!%*",
Значение6 = "_!%*",
Значение7 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение7" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение5 = "_!%*",
Значение6 = "_!%*",
Значение7 = "_!%*",
Значение8 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение8" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение6 = "_!%*",
Значение7 = "_!%*",
Значение8 = "_!%*",
Значение9 = "_!%*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Необходимо добавить описание параметра "Значение9" Why is this an issue?

CODE_SMELL Codesmell  MAJOR Major  :hourglass: 5min effort

Значение = ЗначениеПоУмолчанию;
КонецЕсли;

Значения[- Инд - 1] = Значение;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Слева от '-' не хватает пробела Why is this an issue?

CODE_SMELL Codesmell  INFO Info  :hourglass: 1min effort

@alkoleft alkoleft merged commit fb8ecf6 into develop May 27, 2024
2 of 4 checks passed
@alkoleft alkoleft deleted the feature/288 branch May 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant