Issue-2052: Check if SampleType exists #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2052
ramonski
deleted the
bugfix/issue-2052-attribute-error-for-sampletypeuid-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2052
Description of the issue/feature this PR addresses
Please see #2052 for details
Current behavior before PR
Field accessor fails if no SampleType is set on the Sample
Desired behavior after PR is merged
Field Accessor returns None if no SampleType is set
--
I confirm I have read the Bika LIMS Developer Guidelines and that I have
tested the PR thoroughly and coded it according to PEP8 standards.