do not use localized date for chart js. #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Nov 15, 2017
bika/lims/browser/referencesample.py
Outdated
| @@ -167,6 +167,7 @@ def folderitem(self, obj, item, index): | |||
| # they are not actually used in the table rendering. | |||
| item['Keyword'] = service.getKeyword() | |||
| item['Unit'] = service.getUnit() | |||
| item['CapturedRaw'] = obj.getResultCaptureDate().strftime('%Y-%m-%d %I:%M %p') | |||
There was a problem hiding this comment.
Hi @veroc, did you test this also when the result has no capture date?
There was a problem hiding this comment.
I assumed that there're only results with capture date in this context. Now it returns an empty string on missing date.
xispa
referenced
this pull request
in xispa/senaite.core
Nov 17, 2017
* do not use localized date for chart js. * return empty string on missing capture date. Conflicts: bika/lims/browser/referencesample.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use localized dates for control chart as it breaks the controlchart.js datetime parser.
bika.lims.graphics.controlchart.js
// Convert values to floats
// "2014-02-19 03:11 PM"
x_data_parse = d3.time.format("%Y-%m-%d %I:%M %p").parse;