Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't preallocate so much on vectors and strings. #240

Closed
TyOverby opened this issue Jul 24, 2018 · 1 comment
Closed

Don't preallocate so much on vectors and strings. #240

TyOverby opened this issue Jul 24, 2018 · 1 comment

Comments

@TyOverby
Copy link
Collaborator

#239 (comment)

I don't think that this much preallocation is necessary. We should be able to preallocate several megs at a time without hurting performance too much.
@marc-casperlabs marc-casperlabs mentioned this issue Aug 9, 2020
Closed
mbr added a commit to mbr/bincode that referenced this issue Aug 13, 2020
@mbr
Address questions regarding suitability for storage and untrusted inputs
b49fa0c 
Puts some prominent text into the `readme.md` regarding some use cases
that are likely to be common, along with a few hopefully helpful
pointers to avoid footguns.

Closes bincode-org#345, closes bincode-org#216, addresses bincode-org#240, bincode-org#266.
@mbr mbr mentioned this issue Aug 13, 2020
Merged
ZoeyR pushed a commit that referenced this issue Feb 23, 2021
@mbr
Address questions regarding suitability for storage and untrusted inp…
7b9fa8b 
…uts (#346)

* Address questions regarding suitability for storage and untrusted inputs

Puts some prominent text into the `readme.md` regarding some use cases
that are likely to be common, along with a few hopefully helpful
pointers to avoid footguns.

Closes #345, closes #216, addresses #240, #266.

* Fix typos in `readme.md`

* Remove confusing sentence post 1.0, as requested
@stale
Copy link

stale bot commented Jun 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2021
@stale stale bot closed this as completed Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TyOverby