Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on trunk #408

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Fix CI on trunk #408

merged 3 commits into from
Oct 7, 2021

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Oct 7, 2021

CI was currently broken for two reasons

  • trunk was not compliant with the 1.41 MSRV check
  • clippy had new warnings

Since bincode 2.0 is not even in alpha yet MSRV should not be locked in place. This PR removes the MSRV checks for now. Additionally the few clippy warnings have been resolved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #408 (689787a) into trunk (8bad3bc) will decrease coverage by 0.47%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #408      +/-   ##
==========================================
- Coverage   63.88%   63.41%   -0.48%     
==========================================
  Files          10       10              
  Lines         850      850              
==========================================
- Hits          543      539       -4     
- Misses        307      311       +4     
Impacted Files Coverage Δ
src/de/read.rs 33.33% <66.66%> (ø)
src/de/mod.rs 78.31% <0.00%> (-1.21%) ⬇️
src/config/int.rs 54.28% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bad3bc...689787a. Read the comment docs.

@ZoeyR ZoeyR requested a review from VictorKoenders October 7, 2021 12:12
@ZoeyR ZoeyR merged commit 973ebe3 into trunk Oct 7, 2021
@ZoeyR ZoeyR deleted the fix-ci branch October 14, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants