Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deserde #413

Merged
merged 81 commits into from
Oct 24, 2021
Merged

Feature/deserde #413

merged 81 commits into from
Oct 24, 2021

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Oct 17, 2021

No description provided.

ZoeyR and others added 30 commits June 19, 2021 19:31
src/de/read.rs Outdated
SliceReader { slice: bytes }
}

#[inline(always)]
fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8]> {
fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8], DecodeError> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only used for BorrowReader::take_bytes and nowhere else, what was the reason we split this again?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but it might be needed for the peek_read optimization that got added in trunk. I'll evaluate.

@ZoeyR ZoeyR merged commit c442643 into trunk Oct 24, 2021
@VictorKoenders VictorKoenders deleted the feature/deserde branch October 25, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants