-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deserde #413
Feature/deserde #413
Conversation
… for all basic integer types
… feature combinations
src/de/read.rs
Outdated
SliceReader { slice: bytes } | ||
} | ||
|
||
#[inline(always)] | ||
fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8]> { | ||
fn get_byte_slice(&mut self, length: usize) -> Result<&'storage [u8], DecodeError> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is only used for BorrowReader::take_bytes
and nowhere else, what was the reason we split this again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but it might be needed for the peek_read
optimization that got added in trunk. I'll evaluate.
…/src/derive_* instead
…d the [u8; N] implementations to [T; N]
…nk in documentation.
a95df79
to
eb8625d
Compare
… _with_config functions
No description provided.