Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate qualified Result type in derive #430

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

andrenth
Copy link
Contributor

@andrenth andrenth commented Nov 5, 2021

This prevents problems with generated code when there's an alias for a crate-specific Result type, i.e. type Result<T> = std::result::Result<T, MyError>.

@VictorKoenders
Copy link
Contributor

Thanks!

Just out of sheer interest, how easy did you find it to go through the bincode_derive crate and figure out where you had to change things?

@VictorKoenders VictorKoenders merged commit 4120069 into bincode-org:trunk Nov 5, 2021
@andrenth
Copy link
Contributor Author

andrenth commented Nov 5, 2021

It was pretty easy to find, but honestly I didn't even have to go through the code, because a grep Result derive/src/* pretty much told me what to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants