Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow serde types to be Decode/Encoded #434

Merged
merged 8 commits into from
Nov 9, 2021

Conversation

VictorKoenders
Copy link
Contributor

@VictorKoenders VictorKoenders commented Nov 8, 2021

Adds an attribute that users can add to struct fields

#[derive(bincode::Encode, bincode::Decode)]
struct Foo {
    #[bincode(with_serde)]
    serde: SerdeType
}

Also adds a struct that will wrap any serde type and implements Decode and Encode on it

Closes #433

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #434 (b676dc5) into trunk (a2e7e0e) will decrease coverage by 1.41%.
The diff coverage is 9.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #434      +/-   ##
==========================================
- Coverage   62.97%   61.56%   -1.42%     
==========================================
  Files          46       46              
  Lines        3236     3317      +81     
==========================================
+ Hits         2038     2042       +4     
- Misses       1198     1275      +77     
Impacted Files Coverage Δ
derive/src/derive_enum.rs 0.00% <0.00%> (ø)
derive/src/derive_struct.rs 0.00% <0.00%> (ø)
derive/src/lib.rs 5.33% <0.00%> (ø)
derive/src/parse/mod.rs 90.74% <ø> (ø)
src/features/serde/de_borrowed.rs 0.00% <ø> (ø)
src/features/serde/de_owned.rs 0.00% <ø> (ø)
src/features/serde/mod.rs 0.00% <0.00%> (ø)
src/features/serde/ser.rs 0.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
derive/src/parse/body.rs 64.63% <11.11%> (-3.61%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e7e0e...b676dc5. Read the comment docs.

@VictorKoenders VictorKoenders changed the title [WIP] Allow serde types to be Decode/Encoded Allow serde types to be Decode/Encoded Nov 9, 2021
@VictorKoenders VictorKoenders merged commit cb16c7f into trunk Nov 9, 2021
@VictorKoenders VictorKoenders deleted the feature/serde_attribute branch November 9, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out bincode Decode/Encode interop with serde
3 participants