Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CString compatibility with bincode v1 #502

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Conversation

ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Feb 6, 2022

No description provided.

@ZoeyR ZoeyR requested a review from VictorKoenders February 6, 2022 09:31
@ZoeyR ZoeyR force-pushed the fix-cstring-compat branch from 92b4065 to 90b6786 Compare February 6, 2022 09:32
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #502 (90b6786) into trunk (6c7be9c) will increase coverage by 0.02%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #502      +/-   ##
==========================================
+ Coverage   69.07%   69.09%   +0.02%     
==========================================
  Files          43       44       +1     
  Lines        3056     3058       +2     
==========================================
+ Hits         2111     2113       +2     
  Misses        945      945              
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
tests/issues/issue_498.rs 80.00% <80.00%> (ø)
src/features/impl_std.rs 78.23% <100.00%> (-0.44%) ⬇️
tests/std.rs 100.00% <100.00%> (ø)
src/de/decoder.rs 70.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7be9c...90b6786. Read the comment docs.

@ZoeyR ZoeyR merged commit 2e16e13 into trunk Feb 6, 2022
@VictorKoenders VictorKoenders deleted the fix-cstring-compat branch August 18, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants