Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional to the UnexpectedEnd decode error #522

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

VictorKoenders
Copy link
Contributor

Closes #521

@VictorKoenders VictorKoenders requested a review from ZoeyR March 14, 2022 20:59
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #522 (e4b6b79) into trunk (dadf335) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##            trunk     #522      +/-   ##
==========================================
- Coverage   71.08%   71.02%   -0.06%     
==========================================
  Files          47       47              
  Lines        3178     3182       +4     
==========================================
+ Hits         2259     2260       +1     
- Misses        919      922       +3     
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/features/impl_std.rs 79.64% <0.00%> (-0.97%) ⬇️
src/varint/decode_unsigned.rs 69.41% <ø> (ø)
src/de/read.rs 68.96% <50.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadf335...e4b6b79. Read the comment docs.

@VictorKoenders VictorKoenders merged commit 650fa39 into trunk Mar 17, 2022
@VictorKoenders VictorKoenders deleted the unexpected_end_additional_bytes branch March 17, 2022 10:40
@aviramha
Copy link

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change UnexpectedEnd to include the expected size
3 participants