Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made peek_read take &mut self #572

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Made peek_read take &mut self #572

merged 2 commits into from
Aug 18, 2022

Conversation

VictorKoenders
Copy link
Contributor

Closes #555

@VictorKoenders VictorKoenders requested a review from ZoeyR August 17, 2022 07:22
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #572 (5d40ada) into trunk (9dd19d9) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##            trunk     #572      +/-   ##
==========================================
- Coverage   55.58%   55.56%   -0.03%     
==========================================
  Files          50       50              
  Lines        4305     4305              
==========================================
- Hits         2393     2392       -1     
- Misses       1912     1913       +1     
Impacted Files Coverage Δ
src/features/impl_std.rs 66.34% <0.00%> (ø)
src/de/read.rs 63.63% <100.00%> (-3.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@VictorKoenders VictorKoenders merged commit fd84b77 into trunk Aug 18, 2022
@VictorKoenders VictorKoenders deleted the vko/mut_peek_read branch August 18, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peek_read should be &mut self, not &self
2 participants